Zakelly opened a new pull request, #25317:
URL: https://github.com/apache/flink/pull/25317

   ## What is the purpose of the change
   
   Async state needs to be drained before the snapshot barrier being broadcast 
to downstream. However, there is an issue that we do drain during snapshot. 
This PR fixes this.
   
   
   ## Brief change log
   
    - Move draining logic from `snapshotState` to `prepareSnapshotPreBarrier`.
   
   ## Verifying this change
   
   It's not easy to implement a UT for this. We test this in IT. Future IT for 
SQL operators will also cover this.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to