Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2829
  
    Good additions with the Javadocs. All changes looks good to me.
    ---
    While looking over the Serializer interface I noticed that `clear` and 
`clearCurrentBuffer` are dangerously similar. But looking at the usage it looks 
like it is very important that we don't accidentally call `clear` while copying 
from serializer to target buffers. This should be fixed altogether, but in the 
mean time it would be good to add a big note to the newly added serializer 
comments. What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to