lexluo09 commented on PR #25257: URL: https://github.com/apache/flink/pull/25257#issuecomment-2324509595
> Yes, we should keep compatibility for that. I think in current PR, if it does `builder.cleanupInRocksdbCompactFilter(rocksdbCompactFilterCleanupStrategyProto.getQueryTimeAfterNumEntries());`, the `DEFAULT_PERIODIC_COMPACTION_TIME` still takes effect, aka 30 days set. So no compatibility issues, right? Yes, I also think this is reasonable. The DEFAULT_PERIODIC_COMPACTION_TIME will still be retained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
