1996fanrui commented on code in PR #875:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/875#discussion_r1738428002
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -156,6 +159,9 @@ public boolean scaleResource(
autoScalerStateStore.storeConfigChanges(context, configOverrides);
+ // Try to clear all delayed scale down requests after scaling.
+ delayedScaleDown.clearAll();
Review Comment:
This logic isn't same with the previous logic.
## One demo of previous logic
- 9:00 scale up (be executed)
- 9:30 scale down (ignore)
- 9:59 scale down (ignore)
- 10:00 scale down (can be executed)
## New logic
- 9:00 scale up (be executed, clear all first trigger time)
- 9:30 scale down (update the first trigger time to 9:30)
- 10:00 scale down (within interval from 9:30 to 10:30)
- 10:29 scale down (within interval from 9:30 to 10:30)
- 10:30 scale down (can be executed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
