leosanqing commented on PR #109: URL: https://github.com/apache/flink-connector-elasticsearch/pull/109#issuecomment-2320267238
Thanks for your advices，and I fixed this. Has anybody can review my code? > Thank you for your patch! I am not an official maintainer. Your changes look reasonable, however, they lack test coverage. One other thing I noticed: The newly introduced constant `RETRY_ON_CONFLICT_NUM` does not follow the naming convention of other config options in `ElasticsearchConnectorOptions`: Most of them appear to end on `[...]_OPTION` but do not have the type-indicating suffix. Renaming it to `sink.retries-on-conflict` could eliminate the confusion wether this is a boolean flag or a number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
