GOODBOY008 commented on code in PR #25259:
URL: https://github.com/apache/flink/pull/25259#discussion_r1734863739
##########
flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/DataGeneratorSource.java:
##########
@@ -73,17 +73,17 @@
*
* <p>This source has built-in support for rate limiting. The following code
will produce an
* effectively unbounded (Long.MAX_VALUE from practical perspective will never
be reached) stream of
- * Long values at the overall source rate (across all source subtasks) of 100
events per second.
+ * String values at the overall source rate (across all source subtasks) of
100 events per second.
*
* <pre>{@code
- * GeneratorFunction<Long, Long> generatorFunction = index -> index;
+ * GeneratorFunction<Long, String> generatorFunction = index -> "Number: " +
index;
*
- * DataGeneratorSource<String> source =
+ * DataGeneratorSource<Long> source =
Review Comment:
`Long`->`String`,No need to change.
##########
flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/DataGeneratorSource.java:
##########
@@ -73,17 +73,17 @@
*
* <p>This source has built-in support for rate limiting. The following code
will produce an
* effectively unbounded (Long.MAX_VALUE from practical perspective will never
be reached) stream of
- * Long values at the overall source rate (across all source subtasks) of 100
events per second.
+ * String values at the overall source rate (across all source subtasks) of
100 events per second.
*
* <pre>{@code
- * GeneratorFunction<Long, Long> generatorFunction = index -> index;
+ * GeneratorFunction<Long, String> generatorFunction = index -> "Number: " +
index;
*
- * DataGeneratorSource<String> source =
+ * DataGeneratorSource<Long> source =
* new DataGeneratorSource<>(
- * generatorFunctionStateless,
+ * generatorFunction,
* Long.MAX_VALUE,
* RateLimiterStrategy.perSecond(100),
- * Types.STRING);
+ * Types.LONG);
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
