wqshr12345 commented on code in PR #25233: URL: https://github.com/apache/flink/pull/25233#discussion_r1734036768
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/StateDescriptorUtils.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.v2; + Review Comment: The comment has been addressed. ########## flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/StateDescriptorUtils.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.v2; + +public class StateDescriptorUtils { + private StateDescriptorUtils() {} + + public static org.apache.flink.api.common.state.StateDescriptor transformFromV2ToV1( + StateDescriptor stateDescriptorV2) { + org.apache.flink.api.common.state.StateDescriptor stateDescriptorV1 = + new org.apache.flink.api.common.state.StateDescriptor( + "", stateDescriptorV2.getSerializer(), null) { + @Override + public Type getType() { + StateDescriptor.Type typeV2 = stateDescriptorV2.getType(); + switch (typeV2) { + case VALUE: + return org.apache.flink.api.common.state.StateDescriptor.Type.VALUE; + case LIST: + return org.apache.flink.api.common.state.StateDescriptor.Type.LIST; + case REDUCING: + return org.apache.flink.api.common.state.StateDescriptor.Type + .REDUCING; + case AGGREGATING: + return org.apache.flink.api.common.state.StateDescriptor.Type + .AGGREGATING; + case MAP: + return org.apache.flink.api.common.state.StateDescriptor.Type.MAP; + default: + throw new IllegalArgumentException( + "Unsupported state type: " + typeV2); + } + } + }; + return stateDescriptorV1; Review Comment: The comment has been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
