lvyanquan commented on code in PR #3569:
URL: https://github.com/apache/flink-cdc/pull/3569#discussion_r1729785901


##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Schema.java:
##########
@@ -396,6 +397,9 @@ private void checkColumn(String columnName, DataType type) {
          * @param columnNames columns that form a unique primary key
          */
         public Builder primaryKey(String... columnNames) {
+            for (int i = 0; i < columnNames.length; i++) {
+                columnNames[i] = columnNames[i].toLowerCase();

Review Comment:
   We should avoid modify common class as other connectors may support upper 
case, what about modify this in `PaimonMetaDataApplier`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to