pnowojski commented on code in PR #25228:
URL: https://github.com/apache/flink/pull/25228#discussion_r1726675051


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java:
##########
@@ -77,6 +78,18 @@ public abstract class AbstractS3FileSystemFactory implements 
FileSystemFactory {
                     .withDescription(
                             "Extra arguments to be passed to s5cmd. For 
example, --no-sign-request for public buckets and -r 10 for 10 retries");
 
+    public static final ConfigOption<MemorySize> S5CMD_BATCH_MAX_SIZE =
+            ConfigOptions.key("s3.s5cmd.batch.max-size")

Review Comment:
   FYI @rkhachatryan when I was writing down the documentation (for a different 
PR) I have renamed this parameter from `s3.s5cmd.batch.max-state-size` to 
`s3.s5cmd.batch.max-size` as IMO it sounds better and easier to explain this 
way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to