twalthr commented on code in PR #25230:
URL: https://github.com/apache/flink/pull/25230#discussion_r1725111678
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowFunctionsOperation.java:
##########
@@ -105,6 +107,14 @@ protected Collection<String>
retrieveDataForTableResult(Context ctx) {
}
}
+ public String getDatabaseName() {
Review Comment:
related to my comment above, why all these getters if we can just make the
fields protected. they are not used outside of the class hierarchy right?
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/AbstractShowOperation.java:
##########
@@ -55,6 +57,18 @@ public AbstractShowOperation(
protected abstract String getColumnName();
+ public String getCatalogName() {
Review Comment:
why not just using the protected fields? Now the nullability annotation is
lost with the getters for the IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
