leonardBang commented on code in PR #3560:
URL: https://github.com/apache/flink-cdc/pull/3560#discussion_r1724885602
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -261,4 +261,12 @@ public class MySqlDataSourceOptions {
+ "If there is a need to use a dot (.) in
a regular expression to match any character, "
+ "it is necessary to escape the dot with
a backslash."
+ "eg. db0.\\.*, db1.user_table_[0-9]+,
db[1-2].[app|web]_order_\\.*");
+
+ @Experimental
+ public static final ConfigOption<Boolean>
SCAN_INCREMENTAL_NEWLY_ADDED_TABLE_ENABLED =
+ ConfigOptions.key("scan.incremental.newly-added-table.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Whether to scan the ddl and dml statements of
newly added tables or not in incremental reading stage, by default is false.");
Review Comment:
We should explain the option works phase and the behavior, and also the diff
with SCAN_NEWLY_ADDED_TABLE_ENABLED : do re-snapshot & binlog-reading for
newly added table when restore
SCAN_BINLOG_NEWLY_ADDED_TABLE_ENABLED ： only do binlog-reading for newly
added table during binlog reading phase
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java:
##########
@@ -261,4 +261,12 @@ public class MySqlDataSourceOptions {
+ "If there is a need to use a dot (.) in
a regular expression to match any character, "
+ "it is necessary to escape the dot with
a backslash."
+ "eg. db0.\\.*, db1.user_table_[0-9]+,
db[1-2].[app|web]_order_\\.*");
+
+ @Experimental
+ public static final ConfigOption<Boolean>
SCAN_INCREMENTAL_NEWLY_ADDED_TABLE_ENABLED =
+ ConfigOptions.key("scan.incremental.newly-added-table.enabled")
Review Comment:
scan.binlog.newly-added-table.enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
