leonardBang commented on code in PR #3521:
URL: https://github.com/apache/flink-cdc/pull/3521#discussion_r1721349178


##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java:
##########
@@ -428,6 +428,9 @@ private List<SchemaChangeEvent> 
lenientizeSchemaChangeEvent(SchemaChangeEvent ev
                     }
                     return events;
                 }
+            case DROP_TABLE:
+                // We don't drop any tables in Lenient mode.

Review Comment:
   A INFO log is welcome



##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/SchemaEvolveE2eITCase.java:
##########
@@ -404,6 +408,17 @@ private void validateResult(List<String> expectedEvents, 
ToStringConsumer consum
         }
     }
 
+    private void assertNotExists(List<String> unexpectedEvents, 
ToStringConsumer consumer) {
+        String consumerLog = consumer.toUtf8String();
+        System.out.println(consumerLog);
+        for (String event : unexpectedEvents) {
+            System.out.println("Assuming there's no " + event + " in logs...");

Review Comment:
   remove this line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to