twalthr commented on code in PR #25195:
URL: https://github.com/apache/flink/pull/25195#discussion_r1715236318
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -246,13 +230,19 @@ static Optional<String>
extractFormattedOptions(Map<String, String> conf, String
printIndent,
EncodingUtils.escapeSingleQuotes(entry.getKey()),
EncodingUtils.escapeSingleQuotes(entry.getValue())))
+ .sorted()
Review Comment:
is it guaranteed that this is ROOT sorting, not localized sorting?
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -176,10 +161,7 @@ static String getColumnString(Column column) {
comment -> {
if (StringUtils.isNotEmpty(comment)) {
sb.append(" ");
Review Comment:
remove this line? Why does it not show up in tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
