yuxiqian commented on code in PR #3535:
URL: https://github.com/apache/flink-cdc/pull/3535#discussion_r1714682124
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestEnvironment.java:
##########
@@ -60,16 +60,16 @@
import static org.apache.flink.util.Preconditions.checkState;
-/** Test environment running pipeline job on Flink containers. */
@RunWith(Parameterized.class)
public abstract class PipelineTestEnvironment extends TestLogger {
private static final Logger LOG =
LoggerFactory.getLogger(PipelineTestEnvironment.class);
- @Parameterized.Parameter public String flinkVersion;
+ @Parameterized.Parameter(0)
+ public String flinkVersion;
+
+ @Parameterized.Parameter(1)
+ public String elasticsearchVersion;
Review Comment:
Please rebase it with `master` since there's some conflicts in this file.
##########
flink-cdc-e2e-tests/flink-cdc-pipeline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestEnvironment.java:
##########
@@ -60,16 +60,16 @@
import static org.apache.flink.util.Preconditions.checkState;
-/** Test environment running pipeline job on Flink containers. */
@RunWith(Parameterized.class)
public abstract class PipelineTestEnvironment extends TestLogger {
private static final Logger LOG =
LoggerFactory.getLogger(PipelineTestEnvironment.class);
- @Parameterized.Parameter public String flinkVersion;
+ @Parameterized.Parameter(0)
+ public String flinkVersion;
+
+ @Parameterized.Parameter(1)
+ public String elasticsearchVersion;
Review Comment:
Please rebase it with `master` since there are several conflicts in this
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
