zhuzhurk commented on code in PR #25110:
URL: https://github.com/apache/flink/pull/25110#discussion_r1714627722
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java:
##########
@@ -137,6 +137,9 @@ public class StreamGraph implements Pipeline {
private boolean autoParallelismEnabled;
+ private final transient Map<StreamNode, StreamOperatorFactory<?>>
nodeToHeadOperatorMap =
Review Comment:
I would name it as `nodeToHeadOperatorCache`, because it is just for
speeding up query instead of serve as the ground truth.
And maybe `getHeadOperatorForNode` -> `getHeadOperatorForNodeFromCache`,
`recordHeadOperatorForNode ` -> `cacheHeadOperatorForNode `
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java:
##########
@@ -176,6 +179,14 @@ public CheckpointConfig getCheckpointConfig() {
return checkpointConfig;
}
+ public void recordHeadOperatorForNode(StreamNode node,
StreamOperatorFactory<?> headOperator) {
Review Comment:
Can be package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
