mateczagany commented on PR #860: URL: https://github.com/apache/flink-kubernetes-operator/pull/860#issuecomment-2283318351
After talking with @gyfora I have made it so legacy savepoints will be cleaned up even if FlinkStateSnapshot is enabled for the job. This will use the number of completed FlinkStateSnapshot CRs and subtract that from the `maxCount`. This should help integrating jobs from older operator versions. I have also changed the logic a bit so we extract `metadata.creationTimestamp` to determine the age of the snapshot as `triggerTimestamp` might not always be set (e.g. FlinkStateSnapshot controller did not start). When this PR gets merged, I will also update #862 to test cleaning up legacy savepoints with FlinkStateSnapshot enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
