Re: [PR] [FLINK-36026][table] Options from `OPTIONS` hint should be present in compile plan [flink]

[via GitHub]

snuyanzin commented on code in PR #25186:
URL: https://github.com/apache/flink/pull/25186#discussion_r1713084757


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -83,14 +83,25 @@ void testCompilePlanSql() throws IOException {
                 tableEnv.compilePlanSql("INSERT INTO MySink SELECT * FROM 
MyTable");
         String expected = 
TableTestUtil.readFromResource("/jsonplan/testGetJsonPlan.out");
         assertThat(
-                        TableTestUtil.replaceExecNodeId(
-                                TableTestUtil.replaceFlinkVersion(
-                                        TableTestUtil.getFormattedJson(
-                                                compiledPlan.asJsonString()))))
+                        getPreparedToCompareCompilePlan(
+                                
TableTestUtil.getFormattedJson(compiledPlan.asJsonString())))
                 .isEqualTo(
-                        TableTestUtil.replaceExecNodeId(
-                                TableTestUtil.replaceFlinkVersion(
-                                        
TableTestUtil.getFormattedJson(expected))));
+                        
getPreparedToCompareCompilePlan(TableTestUtil.getFormattedJson(expected)));

Review Comment:
   done in hotfix commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org