leonardBang commented on code in PR #3528:
URL: https://github.com/apache/flink-cdc/pull/3528#discussion_r1711760903
##########
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/UnifiedTransformOperatorTest.java:
##########
@@ -917,6 +917,52 @@ public void testMetadataAndCalculatedTransform() throws
Exception {
.destroyHarness();
}
+ @Test
+ public void testMetadataTransformIncludeMetaColumnString() throws
Exception {
+ TableId tableId = TableId.tableId("my_company", "my_branch",
"schema_nullability");
+ UnifiedTransformTestCase.of(
+ tableId,
+ "id, name, age, id + age as computed, __table_name__
as metaCol1, '__table_name__' as metaCol2,
'__namespace__name__schema__name__table__name__' as metaCol3,
UPPER(__schema_name__) as metaCol4",
Review Comment:
could you also add `__namespace_name__ as metaColNameSpaceName`,
`__schema_name__ as metaColSchemaName` in this test?
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java:
##########
@@ -498,29 +498,15 @@ private static SqlSelect parseProjectionExpression(String
projection) {
return parseSelect(statement.toString());
}
- private static List<Column> copyFillMetadataColumn(
- String transformStatement, List<Column> columns) {
+ private static List<Column> copyFillMetadataColumn(List<Column> columns) {
+ // Add meteColumn for SQLValidater.validate
Review Comment:
metaColumn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
