leonardBang commented on code in PR #3519:
URL: https://github.com/apache/flink-cdc/pull/3519#discussion_r1709493160
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssignerTest.java:
##########
@@ -484,15 +484,33 @@ public void testEnumerateTablesLazily() {
}
@Test
- public void testScanNewlyAddedTableStartFromCheckpoint() {
+ public void
testScanNewlyAddedTableStartFromCheckpoint_INITIAL_ASSIGNING_FINISHED() {
List<String> expected =
Arrays.asList(
"customers_sparse_dist [109] null",
"customers_even_dist null [10]",
"customers_even_dist [10] [18]",
"customers_even_dist [18] null",
"customer_card_single_line null null");
- assertEquals(expected, getTestAssignSnapshotSplitsFromCheckpoint());
+ assertEquals(
+ expected,
+ getTestAssignSnapshotSplitsFromCheckpoint(
+ AssignerStatus.INITIAL_ASSIGNING_FINISHED));
+ }
+
+ @Test
+ public void
+
testScanNewlyAddedTableStartFromCheckpoint_NEWLY_ADDED_ASSIGNING_SNAPSHOT_FINISHED()
{
Review Comment:
minor: The method name should use camel case
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssignerTest.java:
##########
@@ -536,7 +554,7 @@ private List<String> getTestAssignSnapshotSplits(
return getSplitsFromAssigner(assigner);
}
- private List<String> getTestAssignSnapshotSplitsFromCheckpoint() {
+ private List<String>
getTestAssignSnapshotSplitsFromCheckpoint(AssignerStatus assignerStatus) {
Review Comment:
minor: The method name should use camel case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
