yuxiqian commented on code in PR #3482:
URL: https://github.com/apache/flink-cdc/pull/3482#discussion_r1684233027
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisDataSinkOptions.java:
##########
@@ -61,6 +61,12 @@ public class DorisDataSinkOptions {
.withDescription(
"Use automatic redirection of fe without
explicitly obtaining the be list");
+ public static final ConfigOption<String> CHARSET_ENCODING =
+ ConfigOptions.key("charset-encoding")
+ .stringType()
+ .defaultValue("UTF-8")
+ .withDescription("Charset encoding for doris http client,
default UTF-8.");
+
Review Comment:
Could you please mention this new config in docs?
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisMetadataApplier.java:
##########
Review Comment:
Seems this PR also enables Doris connector to apply comments from upstream.
Could you please also add an comment sync E2e case in `MySql2DorisE2eITCase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
