Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2653#discussion_r90479434
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala
---
@@ -451,6 +452,28 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
}
}
+ lazy val tableFunctionCall: PackratParser[LogicalNode] =
+ functionIdent ~ "(" ~ repsep(expression, ",") ~ ")" ^^ {
+ case name ~ _ ~ args ~ _ =>
UnresolvedTableFunctionCall(name.toUpperCase, args)
--- End diff --
Hmm, I think it would be nice to have as few Strings in the Scala Table API
as possible. Ideally, we only need a parser for the Java Table API. Couldn't we
convert the TableFunction into a function call and extend AS to support
multiple names?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
