yuxiqian commented on code in PR #3497:
URL: https://github.com/apache/flink-cdc/pull/3497#discussion_r1694501101
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/testutils/SqlserverCompareUuidTest.java:
##########
Review Comment:
`testutils` are some utility functions for testing, while this case is
actually testing `sqlserver.source.utils`. Putting it in
`test/java/org/apache/flink/cdc/connectors/sqlserver/source/utils` package
makes more sense.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/testutils/SqlserverCompareUuidTest.java:
##########
@@ -0,0 +1,58 @@
+package org.apache.flink.cdc.connectors.sqlserver.testutils;
+
+import org.apache.flink.cdc.connectors.base.utils.ObjectUtils;
+import org.apache.flink.cdc.connectors.sqlserver.source.utils.SqlServerUtils;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+
+public class SqlserverCompareUuidTest {
+ private static final Logger LOG =
LoggerFactory.getLogger(SqlserverCompareUuidTest.class);
+ @Test
+ public void testWorkWithGuids() throws Exception {
Review Comment:
Please use `assertEquals` to verify UUID sorting results instead of logging
them for manual checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
