gyfora commented on code in PR #849:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/849#discussion_r1688103240
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -265,7 +274,7 @@ protected void restoreJob(
throws Exception {
Optional<String> savepointOpt = Optional.empty();
- if (spec.getJob().getUpgradeMode() != UpgradeMode.STATELESS) {
+ if (spec.getJob().getUpgradeMode() == UpgradeMode.SAVEPOINT) {
Review Comment:
The problem is that this cannot be easily done as what savepoint is passed
there will depend on where / why the deploy is called. It is for example
different during initial deployments vs upgrades.
While the optional parameter is not great I would like to avoid adding more
complexity to the deploy method. It may make sense to actually break up the
deploy method in 3 parts, stateless/last-state/savepoint which would get rid of
the optional params + the requireHaMetadata flag at the same time at the
expense of more methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
