Github user Makman2 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2915#discussion_r90423889
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -1372,6 +1381,12 @@
        /** The environment variable name which contains the location of the 
lib folder */
        public static final String ENV_FLINK_LIB_DIR = "FLINK_LIB_DIR";
     
    +   /** The environment variable name which contains the location of the 
bin directory */
    +   public static final String ENV_FLINK_BIN_DIR = "FLINK_BIN_DIR";
    +
    +   /** The environment variable name which contains the Flink installation 
root directory */
    +   public static final String ENV_FLINK_HOME_DIR = "FLINK_HOME";
    +
    --- End diff --
    
    you sure these should be config values? What if someone wants to set these 
to `$MESOS_SANDBOX`, then we need to rely on shell expansion on an already 
started container^^ (Not sure this is a usecase)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to