[
https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15711504#comment-15711504
]
ASF GitHub Bot commented on FLINK-4523:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2916#discussion_r90408543
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
---
@@ -53,6 +56,9 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
/** The initial position to start reading Kinesis streams from (LATEST
is used if not set) */
public static final String STREAM_INITIAL_POSITION =
"flink.stream.initpos";
+ /** The initial timestamp to start reading Kinesis stream from (when
AT_TIMESTAMP is set for STREAM_INITIAL_POSITION */
+ public static final String STREAM_INITIAL_TIMESTAMP =
"flink.stream.init.timestamp";
--- End diff --
What do you think about renaming this to `flink.stream.initpos.timestamp`,
instead of `flink.stream.init.timestamp`?
I personally think it's a good idea to do so, because essentially
`STREAM_INITIAL_TIMESTAMP` is a sub-setting of `STREAM_INITIAL_POSITION`. In
other words, `STREAM_INITIAL_TIMESTAMP` will be meaningless is a
`STREAM_INITIAL_POSITION = AT_TIMESTAMP` isn't set in the config.
> Allow Kinesis Consumer to start from specific timestamp / Date
> --------------------------------------------------------------
>
> Key: FLINK-4523
> URL: https://issues.apache.org/jira/browse/FLINK-4523
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
> Fix For: 1.2.0
>
>
> We had a Kinesis user requesting this feature on an offline chat.
> To be specific, we let all initial Kinesis shards be iterated starting from
> records at the given timestamp.
> The AWS Java SDK we're using already provides API for this, so we can add
> this functionality with fairly low overhead:
> http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/kinesis/model/GetShardIteratorRequest.html#setTimestamp-java.util.Date-
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
