JingGe commented on code in PR #25081:
URL: https://github.com/apache/flink/pull/25081#discussion_r1678345319
##########
pom.xml:
##########
@@ -2389,10 +2389,16 @@ under the License.
<exclude>org.apache.flink.configuration.Configuration#getBytes(java.lang.String,byte[])</exclude>
<exclude>org.apache.flink.configuration.Configuration#setBytes(java.lang.String,byte[])</exclude>
<!-- Disable
check for two sink methods. -->
- <!--
TypeSerializer needs to be considered upgraded to Public. Tracked under
FLINK-35566 -->
<exclude>org.apache.flink.api.connector.sink2.WriterInitContext#createInputSerializer()</exclude>
<!-- SinkV1 is
deprecated but relies on an Experimental interface. Keeping this for legacy
purposes -->
<exclude>org.apache.flink.api.connector.sink2.WriterInitContext#metadataConsumer()</exclude>
+ <!--
TypeSerializer has been considered upgraded to Public. Tracked under
FLINK-35566 -->
+ <exclude>
+
org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility
Review Comment:
could `TypeSerializerSchemaCompatibility` be upgraded to Public too?
##########
pom.xml:
##########
@@ -2389,10 +2389,16 @@ under the License.
<exclude>org.apache.flink.configuration.Configuration#getBytes(java.lang.String,byte[])</exclude>
<exclude>org.apache.flink.configuration.Configuration#setBytes(java.lang.String,byte[])</exclude>
<!-- Disable
check for two sink methods. -->
- <!--
TypeSerializer needs to be considered upgraded to Public. Tracked under
FLINK-35566 -->
<exclude>org.apache.flink.api.connector.sink2.WriterInitContext#createInputSerializer()</exclude>
<!-- SinkV1 is
deprecated but relies on an Experimental interface. Keeping this for legacy
purposes -->
<exclude>org.apache.flink.api.connector.sink2.WriterInitContext#metadataConsumer()</exclude>
+ <!--
TypeSerializer has been considered upgraded to Public. Tracked under
FLINK-35566 -->
Review Comment:
Should this line be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
