Jiabao-Sun commented on PR #37: URL: https://github.com/apache/flink-connector-mongodb/pull/37#issuecomment-2228230597
> Changes looks good to me. (Considering `MongoKeyExtractor` has been widely referenced, it's reasonable for me to keep its name unchanged.) Sorry, I missed that comment. Rename `MongoKeyExtractor` sounds good to me. I think `MongoPrimaryKeyExtractor` is better than `MongoPrimaryKeysExtractor` because it can maintain a consistent naming style with `ResolvedSchema.getPrimaryKey` and `CatalogTable.getPartitionKeys`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
