gtk96 commented on code in PR #3464:
URL: https://github.com/apache/flink-cdc/pull/3464#discussion_r1677378327


##########
docs/content.zh/docs/connectors/flink-sources/postgres-cdc.md:
##########
@@ -470,7 +470,6 @@ public class PostgresParallelSourceExample {
                         .slotName("flink")
                         .decodingPluginName("decoderbufs") // use pgoutput for 
PostgreSQL 10+
                         .deserializer(deserializer)
-                        .includeSchemaChanges(true) // output the schema 
changes as well

Review Comment:
   > Seems this undocumented method still exists in `PostgresSourceExampleTest` 
and 
`org.apache.flink.cdc.connectors.postgres.source.PostgresSourceBuilder#includeSchemaChanges`.
 Should they be deprecated / removed, too?
   
   Yes, I think it should be removed as well, thank you for reminding me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to