fhueske commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1674108789
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/JsonUnquoteFunction.java: ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.data.binary.BinaryStringData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.SpecializedFunction.SpecializedContext; +import org.apache.flink.table.runtime.functions.SqlJsonUtils; + +import javax.annotation.Nullable; + +/** Implementation of {@link BuiltInFunctionDefinitions#JSON_UNQUOTE}. */ +@Internal +public class JsonUnquoteFunction extends BuiltInScalarFunction { + + public JsonUnquoteFunction(SpecializedContext context) { + super(BuiltInFunctionDefinitions.JSON_UNQUOTE, context); + } + + public @Nullable Object eval(Object input) { + if (input == null) { + return null; + } + BinaryStringData bs = (BinaryStringData) input; + String inputStr = bs.toString(); + try { + if (isValidJsonVal(inputStr)) { + return new BinaryStringData(unescapeValidJson(inputStr)); + } + } catch (Throwable t) { + // ignore + } Review Comment: I don't think we should swallow any kind of exception or error. Let's catch the errors that we expect (IllegalArgumentException, etc.) and handle those by returning the original input. Unexpected exceptions should be forwarded because they might be related to other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
