[ 
https://issues.apache.org/jira/browse/FLINK-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705899#comment-15705899
 ] 

ASF GitHub Bot commented on FLINK-5109:
---------------------------------------

GitHub user Hapcy opened a pull request:

    https://github.com/apache/flink/pull/2898

    [FLINK-5109] fix invalid content-encoding header of webmonitor

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [x] Documentation --- not touched
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Hapcy/flink 
5109_invalid_content_encoding_header_in_rest_api_responses

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2898.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2898
    
----
commit aa105aa7160640548eac99c56af3afb5af377249
Author: tibor.moger <tibor.mo...@smartx.eu>
Date:   2016-11-28T15:51:47Z

    [FLINK-5109] fix invalid content-encoding header of webmonitor

----


> Invalid Content-Encoding Header in REST API responses
> -----------------------------------------------------
>
>                 Key: FLINK-5109
>                 URL: https://issues.apache.org/jira/browse/FLINK-5109
>             Project: Flink
>          Issue Type: Bug
>          Components: Web Client, Webfrontend
>    Affects Versions: 1.1.0, 1.2.0, 1.1.1, 1.1.2, 1.1.3
>            Reporter: Móger Tibor László
>              Labels: http-headers, rest_api
>
> On REST API calls the Flink runtime responds with the header 
> Content-Encoding, containing the value "utf-8". According to the HTTP/1.1 
> standard this header is invalid. ( 
> https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.5 ) 
> Possible acceptable values are: gzip, compress, deflate. Or it should be 
> omitted.
> The invalid header may cause malfunction in projects building against Flink.
> The invalid header may be present in earlier versions aswell.
> Proposed solution: Remove lines from the project, where CONTENT_ENCODING 
> header is set to "utf-8". (I could do this in a PR.)
> Possible solution but may need further knowledge and skills than mine: 
> Introduce content-encoding. Doing so may need some configuration beacuse then 
> Flink would have to encode the responses properly (even paying attention to 
> the request's Accept-Encoding headers).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to