snuyanzin commented on code in PR #24996: URL: https://github.com/apache/flink/pull/24996#discussion_r1666413889
########## README.md: ########## @@ -69,8 +69,8 @@ Prerequisites for building Flink: * Unix-like environment (we use Linux, Mac OS X, Cygwin, WSL) * Git -* Maven (we require version 3.8.6) -* Java 8 or 11 (Java 9 or 10 may work) +* Maven (we require version 4.0.0) +* Java 17 or 21 Review Comment: If you look at code there is still maven 3.8.6 https://github.com/apache/flink/blob/6b08eb15d09d6c8debb609b8b3a2a241ca855155/.mvn/wrapper/maven-wrapper.properties#L19 if you look at ci pipelines there is still jdk8 e.g. https://github.com/apache/flink/blob/6b08eb15d09d6c8debb609b8b3a2a241ca855155/tools/azure-pipelines/build-apache-repo.yml#L75 https://github.com/apache/flink/blob/6b08eb15d09d6c8debb609b8b3a2a241ca855155/tools/azure-pipelines/build-apache-repo.yml#L108 these are just some examples, in fact there are more Also if you look at release doc (https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release) there are maven 3.8.6 and java 8 all this should be discussed/fixed before the doc update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
