Github user BorisOsipov commented on a diff in the pull request:
https://github.com/apache/flink/pull/2843#discussion_r89996713
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -361,17 +351,18 @@ public String select(Map<String, Event> pattern) {
}
);
- result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
+ result.addSink(resultSink);
--- End diff --
I didn't find any of use`DataStreamUtils#collect()` in Flink tests.
`DataStreamUtils#collect()` places in
`<artifactId>flink-contrib</artifactId>` module. Are you sure that is a good
idea to depend on it?
I moved classes because I saw at least four implementations String\List
sinks for testing purpose. I guess it's a good idea to migrate to one of them
and get rid of usage temp files where possible.
What do you think? I'm newbie in a Flink and maybe wrong understand smth
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
