gaborgsomogyi commented on code in PR #24914:
URL: https://github.com/apache/flink/pull/24914#discussion_r1634351465
##########
flink-connectors/flink-file-sink-common/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/OutputStreamBasedPartFileWriter.java:
##########
@@ -50,7 +50,7 @@ public abstract class OutputStreamBasedPartFileWriter<IN,
BucketID>
@Nullable final Path targetPath;
- private CompactingFileWriter.Type writeType = null;
+ private Type writeType = null;
Review Comment:
Reading the code and seeing `Type` purely requires some digging. Changing
the name to `WriterType` would be unnecessary duplication so I would vote on
have prefixed from where it comes from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
