ramkrish86 commented on code in PR #24896:
URL: https://github.com/apache/flink/pull/24896#discussion_r1634237585


##########
flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/fs/hdfs/BaseHadoopFsRecoverableFsDataOutputStream.java:
##########
@@ -59,7 +59,7 @@ public void write(byte[] b, int off, int len) throws 
IOException {
 
     @Override
     public void flush() throws IOException {
-        out.hsync();
+        out.hflush();

Review Comment:
   I checked this change. In ABFS case hflush and hsync internally does the 
same I believe. So that functionality might not break. In HDFS case yes this 
might make things costly. Thanks for fixing this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to