hlteoh37 commented on code in PR #142:
URL: 
https://github.com/apache/flink-connector-aws/pull/142#discussion_r1632760932


##########
flink-connector-aws/flink-connector-kinesis/pom.xml:
##########
@@ -354,6 +354,12 @@ under the License.
                             <relocations combine.children="override">
                                 <!-- Do not relocate guava because it is 
exposed in the Kinesis API (KinesisProducer#addUserRecord).
                                      Users may be using other affected API's, 
so relocations may break user-code -->
+                                <relocation>
+                                    
<pattern>org.apache.flink.connector.aws.sink</pattern>
+                                    <shadedPattern>
+                                        
org.apache.flink.kinesis.shaded.org.apache.flink.connector.aws.sink
+                                    </shadedPattern>

Review Comment:
   Would this affect snapshot state compatibility?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to