twalthr commented on code in PR #24869:
URL: https://github.com/apache/flink/pull/24869#discussion_r1625562520
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -276,6 +277,16 @@ public long getLatencyTrackingInterval() {
return configuration.get(MetricOptions.LATENCY_INTERVAL).toMillis();
}
+ @PublicEvolving
+ public Optional<MemorySize> getGlobalAggregationBufferSize() {
Review Comment:
You are mixing layers here. Global aggregation is a concept of the SQL layer
and thus should only change classes in the `flink-table` module. Configuration
doesn't need to be added to `ExecutionConfig`. You can pass parameters to the
runtime class during planning in the corresponding ExecNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
