z3d1k commented on code in PR #24875: URL: https://github.com/apache/flink/pull/24875#discussion_r1624013219
########## flink-python/setup.py: ########## @@ -317,13 +317,13 @@ def extracted_output_files(base_dir, file_path, output_directory): 'pyflink.bin': ['*']} install_requires = ['py4j==0.10.9.7', 'python-dateutil>=2.8.0,<3', - 'apache-beam>=2.43.0,<2.49.0', + 'apache-beam>=2.52.0', Review Comment: Should there be an upper bound for dependency version to prevent breaking changes coming in? Or can we make this version fixed (use `==`)? ########## flink-python/pyproject.toml: ########## @@ -21,7 +21,7 @@ requires = [ "packaging>=20.5; platform_machine=='arm64'", # macos M1 "setuptools>=18.0", "wheel", - "apache-beam>=2.43.0,<2.49.0", + "apache-beam>=2.52.0", Review Comment: Should there be an upper bound for dependency version to prevent breaking changes coming in? Or can we make this version fixed (use `==`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org