1996fanrui commented on code in PR #24685:
URL: https://github.com/apache/flink/pull/24685#discussion_r1597784913
##########
flink-core/src/test/java/org/apache/flink/core/memory/CrossSegmentTypeTest.java:
##########
@@ -86,15 +84,15 @@ private void testCompare(MemorySegment seg1, MemorySegment
seg2, Random random)
int cmp = seg1.compare(seg2, pos1, pos2, len);
if (pos1 < pos2 - shift) {
- assertTrue(cmp <= 0);
+ assertThat(cmp).isLessThanOrEqualTo(0);
} else {
- assertTrue(cmp >= 0);
+ assertThat(cmp >= 0).isTrue();
Review Comment:
```suggestion
assertThat(cmp).isGreaterThanOrEqualTo(0);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
