liuml07 opened a new pull request, #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105
https://issues.apache.org/jira/browse/FLINK-35472 > Per discussion in [this PR](https://github.com/apache/flink-connector-elasticsearch/pull/104), it makes the tests more reusable if we use parameterized tests. It requires some changes of the existing tests, which includes: > > - Make base test class parameterized with secure parameter. As JUnit 5 has limited support for parameterized tests with inheritance, we can use the ParameterizedTestExtension introduced in Flink, see this doc > - Manage the test container lifecycle instead of using the managed annotation @Testcontainers and @Container so that the test containers can be used as a singleton for all tests in the suite > - Create and use common methods in the base class that concrete test classes can be mostly parameter-agnostic This JIRA intends to not change any logic or functionality. Instead it focuses on tests refactoring for more reusable tests and future proof. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
