morazow commented on code in PR #24426:
URL: https://github.com/apache/flink/pull/24426#discussion_r1616229933
##########
.github/workflows/nightly.yml:
##########
@@ -94,3 +94,46 @@ jobs:
s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }}
s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }}
s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }}
+
+ build_python_wheels:
+ name: "Build Python Wheels on ${{ matrix.os_name }}"
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - os: ubuntu-latest
+ os_name: linux
+ - os: macos-latest
+ os_name: macos
+ steps:
+ - name: "Checkout the repository"
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: "Stringify workflow name"
+ uses: "./.github/actions/stringify"
+ id: stringify_workflow
+ with:
+ value: ${{ github.workflow }}
+ - name: "Build python wheels for ${{ matrix.os_name }}"
+ uses: pypa/cibuildwheel@v2.16.5
Review Comment:
Ahh I see. I would be fine to use generic install aproach, right?
```
# Used to host cibuildwheel
- uses: actions/setup-python@v5
- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.18.1
- name: Build wheels
run: python -m cibuildwheel --output-dir wheelhouse
```
cibuildwheel docs also suggest this generic way for GitHub actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
