Zakelly commented on code in PR #24807:
URL: https://github.com/apache/flink/pull/24807#discussion_r1616015660
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -569,6 +581,67 @@ public void reusePreviousStateHandle(
}
}
+ // ------------------------------------------------------------------------
+ // Space Control
+ // ------------------------------------------------------------------------
+
+ /**
+ * The core method that control space if needed. This method will compare
the desired space
+ * amplification with current one, and if it exceeds the configured
amplification, this method
+ * will mark minimal set of {@link PhysicalFile}s not to be reused anymore.
+ */
+ private void controlSpace() {
+ if (spaceStat.logicalFileSize.get() * maxSpaceAmplification
Review Comment:
Since there still be another code getting value from `spaceStat` and
calculate with `maxSpaceAmplification` (Line 598), I'd suggest keep this as it
is. Could you elaborate more on the metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
