Zakelly commented on code in PR #24846:
URL: https://github.com/apache/flink/pull/24846#discussion_r1615993191
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -131,19 +131,22 @@ public abstract class FileMergingSnapshotManagerBase
implements FileMergingSnaps
/**
* The {@link DirectoryStreamStateHandle} for shared state directories,
one for each subtask.
*/
+ @GuardedBy("lock")
Review Comment:
Or adding @GuardedBy("lock") to each of those above variables would be fine
with me.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -131,19 +131,22 @@ public abstract class FileMergingSnapshotManagerBase
implements FileMergingSnaps
/**
* The {@link DirectoryStreamStateHandle} for shared state directories,
one for each subtask.
*/
+ @GuardedBy("lock")
Review Comment:
Or adding `@GuardedBy("lock")` to each of those above variables would be
fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
