luismacosta commented on code in PR #829:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/829#discussion_r1615929553


##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -23,6 +23,11 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     {{- include "flink-operator.labels" . | nindent 4 }}

Review Comment:
   From what I can see in 
[flink-operator.labels](https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/_helpers.tpl#L54)
 there is no way to add more labels. 
   To achieve that, my idea here was to add to metadata.labels the same the is 
configured at 
[spec.template.metadata.labels](https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/flink-operator.yaml#L36-L41).
 That way I can define them in mu values.yaml (.Values.operatorPod)



##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -23,6 +23,11 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     {{- include "flink-operator.labels" . | nindent 4 }}

Review Comment:
   From what I can see in 
[flink-operator.labels](https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/_helpers.tpl#L54)
 there is no way to add more labels. 
   To achieve that, my idea here was to add to metadata.labels the same the is 
configured at 
[spec.template.metadata.labels](https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/flink-operator.yaml#L36-L41).
 That way I can define them in my values.yaml (.Values.operatorPod)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to