morazow commented on code in PR #3349:
URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1612232449
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDialect.java:
##########
@@ -217,6 +220,11 @@ public JdbcSourceFetchTaskContext
createFetchTaskContext(JdbcSourceConfig taskSo
@Override
public void notifyCheckpointComplete(long checkpointId, Offset offset)
throws Exception {
Review Comment:
Yes, maybe PostgresSourceReader is good option.
I didn't want to have it in IncrementalSourceReaderWithCommit since this is
only PG related feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
