[jira] [Commented] (FLINK-5167) StreamExecutionEnvironment's set function return `this` instead of void

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697465#comment-15697465
 ] 

ASF GitHub Bot commented on FLINK-5167:
---------------------------------------

GitHub user shijinkui opened a pull request:

    https://github.com/apache/flink/pull/2874

    [FLINK-5167] StreamExecutionEnvironment set function return `this` in…

    StreamExecutionEnvironment's set function return `this` instead of void
    
    for example :
    
    public void setNumberOfExecutionRetries(int numberOfExecutionRetries) { 
      config.setNumberOfExecutionRetries(numberOfExecutionRetries); 
    }
    
    change to:
    
    public StreamExecutionEnvironment setNumberOfExecutionRetries(int 
numberOfExecutionRetries) { 
      config.setNumberOfExecutionRetries(numberOfExecutionRetries); 
      return this; 
    }
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-5167] 
StreamExecutionEnvironment's set function return `this` instead of void")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shijinkui/flink FLINK-5166

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2874
    
----
commit b28992af876c33e00f86d27e1dd6ef783fefa3a0
Author: shijinkui <shijin...@huawei.com>
Date:   2016-11-26T06:47:07Z

    [FLINK-5167] StreamExecutionEnvironment set function return `this` instead 
of void

----


> StreamExecutionEnvironment's set function return `this` instead of void
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5167
>                 URL: https://issues.apache.org/jira/browse/FLINK-5167
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: shijinkui
>
> for example :
> public void setNumberOfExecutionRetries(int numberOfExecutionRetries) {
>       config.setNumberOfExecutionRetries(numberOfExecutionRetries);
> }
> change to:
> public StreamExecutionEnvironment setNumberOfExecutionRetries(int 
> numberOfExecutionRetries) {
>       config.setNumberOfExecutionRetries(numberOfExecutionRetries);
>       return this;
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)