yuxiqian commented on code in PR #1907:
URL: https://github.com/apache/flink-cdc/pull/1907#discussion_r1595223016
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlTableSourceFactory.java:
##########
@@ -189,6 +198,7 @@ public Set<ConfigOption<?>> optionalOptions() {
options.add(MySqlSourceOptions.HEARTBEAT_INTERVAL);
options.add(MySqlSourceOptions.SCAN_INCREMENTAL_SNAPSHOT_CHUNK_KEY_COLUMN);
options.add(MySqlSourceOptions.SCAN_INCREMENTAL_SNAPSHOT_BACKFILL_SKIP);
+ options.add(CHANGELOG_MODE);
Review Comment:
```suggestion
options.add(MySqlSourceOptions.CHANGELOG_MODE);
```
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlTableSourceFactory.java:
##########
@@ -47,6 +48,8 @@
import java.util.Set;
import java.util.regex.Pattern;
+import static org.apache.flink.cdc.common.utils.Preconditions.checkArgument;
+import static
org.apache.flink.cdc.connectors.mysql.source.config.MySqlSourceOptions.CHANGELOG_MODE;
Review Comment:
Maybe use qualified `MySqlSourceOptions.CHANGELOG_MODE` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
