wzorgdrager commented on code in PR #24756:
URL: https://github.com/apache/flink/pull/24756#discussion_r1592097458
##########
flink-python/pyflink/common/types.py:
##########
@@ -177,7 +177,10 @@ def of_kind(row_kind: RowKind, *args, **kwargs):
return row
def __contains__(self, item):
- return item in self._values
+ if hasattr(self, "_fields"):
+ return item in self._fields
Review Comment:
so then the question is, if `_fields` is None do we want to fallback and do
a membership check for the values or always just return False?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
