yunfengzhou-hub commented on code in PR #24698: URL: https://github.com/apache/flink/pull/24698#discussion_r1578908743
########## flink-core-api/src/main/java/org/apache/flink/util/function/ConsumerWithException.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.util.function; + +import java.util.function.Consumer; + +/** + * A checked extension of the {@link Consumer} interface. + * + * @param <T> type of the first argument + * @param <E> type of the thrown exception + */ +public interface ConsumerWithException<T, E extends Throwable> { Review Comment: It might be simpler to reuse `org.apache.flink.util.function.ThrowingConsumer`. ########## flink-core-api/src/main/java/org/apache/flink/api/common/state/v2/StateFuture.java: ########## @@ -49,7 +49,7 @@ public interface StateFuture<T> { * @param action the action to perform before completing the returned StateFuture. * @return the new StateFuture. */ - StateFuture<Void> thenAccept(Consumer<? super T> action); + StateFuture<Void> thenAccept(ConsumerWithException<? super T, ? extends Exception> action); Review Comment: Given that java CompletableFuture use the following signatures to handle exceptions ```java CompletableFuture<Void> thenAccept(Consumer<? super T> action); CompletableFuture<T> whenComplete(BiConsumer<? super T,? super Throwable> action); ``` Would it be better to align the APIs here with CompletableFuture? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
