anupamaggarwal commented on code in PR #24482: URL: https://github.com/apache/flink/pull/24482#discussion_r1548361941
########## flink-formats/flink-protobuf-confluent-registry/src/main/java/org/apache/flink/formats/protobuf/registry/confluent/ProtoRegistrySerializationSchema.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.formats.protobuf.registry.confluent; + +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.util.FlinkRuntimeException; +import org.apache.flink.util.Preconditions; + +import com.google.protobuf.DynamicMessage; +import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient; +import io.confluent.kafka.schemaregistry.protobuf.ProtobufSchema; +import org.apache.kafka.common.utils.ByteUtils; + +import java.io.ByteArrayOutputStream; +import java.nio.ByteBuffer; +import java.util.Objects; + +/** + * Serialization schema that serializes an object of Flink internal data structure with a Protobuf + * format. + * + * <p>Result <code>byte[]</code> messages can be deserialized using {@link + * ProtoRegistryDeserializationSchema}. + */ +public class ProtoRegistrySerializationSchema implements SerializationSchema<RowData> { + + private static final long serialVersionUID = 1L; + + /** RowType to generate the runtime converter. */ + private final RowType rowType; + + private final SchemaRegistryConfig schemaRegistryConfig; + + /** The converter that converts internal data formats to JsonNode. */ + private transient RowDataToProtoConverters.RowDataToProtoConverter runtimeConverter; + + private transient SchemaRegistryCoder schemaCoder; + /** Output stream to write message to. */ + private transient ByteArrayOutputStream arrayOutputStream; + + public ProtoRegistrySerializationSchema(SchemaRegistryConfig registryConfig, RowType rowType) { + this.rowType = Preconditions.checkNotNull(rowType); + this.schemaRegistryConfig = Preconditions.checkNotNull(registryConfig); + } + + @Override + public void open(InitializationContext context) throws Exception { + final SchemaRegistryClient schemaRegistryClient = schemaRegistryConfig.createClient(); + this.schemaCoder = + new SchemaRegistryCoder(schemaRegistryConfig.getSchemaId(), schemaRegistryClient); + final ProtobufSchema schema = + (ProtobufSchema) + schemaRegistryClient.getSchemaById(schemaRegistryConfig.getSchemaId()); + this.runtimeConverter = + RowDataToProtoConverters.createConverter(rowType, schema.toDescriptor()); + this.arrayOutputStream = new ByteArrayOutputStream(); + } + + @Override + public byte[] serialize(RowData row) { + try { + final DynamicMessage converted = (DynamicMessage) runtimeConverter.convert(row); + + arrayOutputStream.reset(); + schemaCoder.writeSchema(arrayOutputStream); + final ByteBuffer buffer = writeMessageIndexes(); + arrayOutputStream.write(buffer.array()); + converted.writeTo(arrayOutputStream); + return arrayOutputStream.toByteArray(); + } catch (Throwable t) { + throw new FlinkRuntimeException(String.format("Could not serialize row '%s'.", row), t); + } + } + + private static ByteBuffer writeMessageIndexes() { + //write empty message indices for now + ByteBuffer buffer = ByteBuffer.allocate(ByteUtils.sizeOfVarint(0)); + ByteUtils.writeVarint(0, buffer); + return buffer; Review Comment: thanks @klam-shop, I added logic for handling message indexes, pls lmk if it does not makes sense. - For the case, wherein the schemaID is specified explicitly through config, the message indexes are determined via another config parameter - message-name. They are skipped during deserialization, since the correct schema descriptor to use is determined during initialization (from message-name). - For the case where pre-registered schemaId is not available, we write empty message indexes. For deserialization the message indexes are read from the inputstream for inferring the right schema to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
