[
https://issues.apache.org/jira/browse/FLINK-34239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829635#comment-17829635
]
Kumar Mallikarjuna commented on FLINK-34239:
--------------------------------------------
Hello [~Zhanghao Chen] , [~zjureel], I've raised a PR for the change. Could you
please take a look! Thanks! :)
> Introduce a deep copy method of SerializerConfig for merging with Table
> configs in org.apache.flink.table.catalog.DataTypeFactoryImpl
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-34239
> URL: https://issues.apache.org/jira/browse/FLINK-34239
> Project: Flink
> Issue Type: Sub-task
> Components: API / Core
> Affects Versions: 1.19.0
> Reporter: Zhanghao Chen
> Assignee: Kumar Mallikarjuna
> Priority: Major
> Labels: pull-request-available
>
> *Problem*
> Currently,
> org.apache.flink.table.catalog.DataTypeFactoryImpl#createSerializerExecutionConfig
> will create a deep-copy of the SerializerConfig and merge Table config into
> it. However, the deep copy is done by manully calling the getter and setter
> methods of SerializerConfig, and is prone to human errors, e.g. missing
> copying a newly added field in SerializerConfig.
> *Proposal*
> Introduce a deep copy method for SerializerConfig and replace the curr impl
> in
> org.apache.flink.table.catalog.DataTypeFactoryImpl#createSerializerExecutionConfig.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
